Skip to content

Make join! description more accurate #93256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2022
Merged

Make join! description more accurate #93256

merged 1 commit into from
Jan 30, 2022

Conversation

EFanZh
Copy link
Contributor

@EFanZh EFanZh commented Jan 24, 2022

No description provided.

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 29, 2022
@camelid
Copy link
Member

camelid commented Jan 29, 2022

r? @joshtriplett

@joshtriplett
Copy link
Member

joshtriplett commented Jan 29, 2022 •
edited
Loading

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 29, 2022

📌 Commit 571356c has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2022
@bors
Auto merge of rust-lang#93468 - matthiaskrgr:rollup-vxullvd, r=matthi…
7cc28c1 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#93256 (Make `join!` description more accurate)
 - rust-lang#93358 (Add note suggesting that predicate may be satisfied, but is not `const`)
 - rust-lang#93362 (Do not register infer var for GAT projection in RPIT)
 - rust-lang#93391 (rustdoc: remove tooltip from source link)
 - rust-lang#93414 (Move unstable is_{arch}_feature_detected! macros to std::arch)
 - rust-lang#93441 (rustdoc: load the set of in-scope traits for modules with no docstring)
 - rust-lang#93459 (fs: Don't copy d_name from struct dirent)
 - rust-lang#93463 (Rename _args -> args in format_args expansion)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6e2593d into rust-lang:master Jan 30, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 30, 2022
@EFanZh EFanZh deleted the patch-1 branch January 3, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibraheemdev ibraheemdev ibraheemdev approved these changes

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@EFanZh @camelid @joshtriplett @bors @ibraheemdev @rustbot